Rendered at 07:50:50 GMT+0000 (Coordinated Universal Time) with Netlify.
riteshyadav02 17 minutes ago [-]
Very cool. How are you handling large diffs performance-wise? Are you rendering the whole buffer or virtualizing the viewport?
Also curious why you chose Rust TUI instead of building on top of something like delta.
llbbdd 12 hours ago [-]
I was looking for a good TUI tool for diffs recently, but I'm not sure yet if what I want exists already (and I don't think this tool does it (yet?)). I've been moving my workflow out of VSCode as I'm using TUI-driven coding agents more often lately but one thing I miss from my VSCode/GitHub workflow is the ability to provide a comment on lines or ranges in a diff to provide targeted feedback to the agent. Most diff tools seem to be (rightfully) focused on cleanly visualizing changes and not necessarily iterating on the change.
I admit I haven't looked super hard yet, I settled on configuring git to use delta [0] for now and I'm happy with it, but I'm curious if anyone has a workflow for reviewing/iterating on diffs in the terminal that they'd be willing to share. Also open to being told that I'm lightyears behind and that there's a better mental model for this.
*Edit: I see you meant providing feedback to an agent, not a PR. Well that's what I get for reading too fast.
llbbdd 10 hours ago [-]
No problem, I appreciate another reason to look at Neovim; I do sometimes have a need to interact with GH's actual PR flow and once I've moved the rest of my workflow out of VSCode, Neovim looks like the best option for the last mile of actually writing and editing code. I just have to commit the time to set it up with everything I probably take for granted in VSCode's editor.
thamer 10 hours ago [-]
I had tried `delta` a few years ago but eventually went with `diff-so-fancy`[1]
The two are kind of similar if I remember correctly, and both offer a lot of config options to change the style and more. I mostly use it for diffs involving long lines since it highlights changes within a line, which makes it easier to spot such edits.
I have an alias set in `~/.gitconfig` to pipe the output of `git diff` (with options) to `diff-so-fancy` with `git diffs`:
You can do this with diff-highlight, which comes packaged with git. No extra packages needed.
agavra 8 hours ago [-]
Checkout https://github.com/agavra/tuicr - it's built exactly for this purpose (reviewing code in your terminal and then adding comments and exporting it to an agent to fix).
flamestro 10 hours ago [-]
I was also searching for some time, but most of them did not have enough context for my workflow tbh. So thats why I decided to make deff. Another good one I liked is vimdiff
mckn1ght 11 hours ago [-]
I use delta for quick diffs in a shell (along with the -U0 option on git-diff), but in my claude workflow, i have a 3 pane setup in tmux: :| where the right side is a claude session, the top left is emacs opened to magit, and the bottom left is a shell. Magit makes navigating around a diff pretty easy (as well as all the other git operations), and I can dive into anything and hand edit as well.
jfyne 11 hours ago [-]
Not TUI based but I made something called meatcheck. The idea being that the LLM requests a review from the human, you can leave inline comments like a PR review.
Once you submit it outputs to stdout and the agent reads your comments and actions them.
Thank you! At a glance this is very close to what I had in mind, especially with the straightforward output format, I'll give this a try.
coryrc 11 hours ago [-]
magit
ushironoko 9 minutes ago [-]
[dead]
k_bx 12 hours ago [-]
What I would love to see is "tig" replacement that is:
- even faster, especially if you have couple thousand files and just want to press "u" for some time and see them very quickly all get staged
- has this split-view diff opened for a file
Otherwise tig is one of my favorite tools to quickly commit stuff without too many key presses but with review abilities, i have its "tig status" aliased to "t"
rileymichael 13 hours ago [-]
getting users to adopt a new tool with its own incantations is a tough sell. git supports specifying an external pager so folks can plug in alternatives (such as https://github.com/dandavison/delta) while still using the familiar git frontend
This looks great as well! I personally prefer a bit more context. Thats why I added a bit more of it to deff. It also allows to mark files as reviewed by pressing `r` which is quite handy for my flow.
lf-non 13 hours ago [-]
I also use icdiff, but it is good to have the file-awareness for git diff esp. the ability to quickly skip files that I know aren't important.
Amorymeltzer 12 hours ago [-]
For that in particular, I use delta (<https://github.com/dandavison/delta>) with `side-by-side = true` enabled. I find I use both icdiff and delta side-by-side on a regular basis.
behnamoh 12 hours ago [-]
Delta is so much faster than icdiff too.
ZoomZoomZoom 12 hours ago [-]
Why shouldn't this be a simple wrapper to tie Delta to some kind of file browser or a thing like television[1]?
The specific gap side-by-side covers for me is reviewing changes on a remote box without firing up an IDE. Delta is great but keeps the unified format. icdiff does the split view but is pretty barebones. So there's definitely space here.
What nobody's mentioned yet is difftastic. Takes a completely different approach - parses syntax trees instead of lines, so indentation changes and bracket shuffles don't show up as noise. Worth a look if you're comparing options.
Main question I'd have: how does it hold up on large files? 5k+ line diffs are where most of these tools either choke or produce unreadable output. That'd be the test I'd run first.
flamestro 11 hours ago [-]
So I tested this on huge files (checking cargo lock for instance) and it is super fast in the navigation of those. Until now I did not encounter any issue with bigger files (around 4k-6k changes but also only 4k-6k lines).
I personally find vimdiff a bit harder to navigate for my usecase. The reason is that I am context unaware of the file often in larger projects and wanted something that allows me to check all lines in a touched file. However, I have to admit vimdiff comes quite close to what I need and is a great tool!
I ran in to a couple problems when trying that script (details below), but I'm really happy that you shared it, because I had not seen ':windo diffthis' before, and that method of scripting diffs. I'll definitely be customising it!
(I found that my mac machine doesn't support the '-printf' option, and also I was attempting to run 'git bvd main' on a branch but it seems it does a recursive directory diff, so I'll use 'git diff --name-only' as the input to the awk command).
Edit: worked nicely! I haven't used tabs much in vim so is a slightly new workflow but otherwise very handy
metalliqaz 12 hours ago [-]
but is it blazingly fast?
syngrog66 12 hours ago [-]
if its not in Rust or browser-based or a "cloud" service or the result of multi-GWH of LLM "training" or a VSCode plugin or ideally all of the prior then the HN kids wont be interested :-)
suralind 9 hours ago [-]
What you want is difftastic. No need to thank me.
spartanatreyu 8 hours ago [-]
You definitely need a gif or apng file showing it's use in the github readme.
And a link to an asciicinema would help a lot too.
---
Also, I'm not sure how useful the side-by-side view is.
The left side has lines 1365-1371 having the same code as lines 1374-1380 on the right side, yet they're not aligned with each other.
Most diff views would put padding between lines 1364-1365 on the left side so lines 1365-1371 are aligned with 1374-1380 on the right side.
raphinou 12 hours ago [-]
Looks interesting. I'm currently using https://tuicr.dev/ , of which I like that the first screen it shows is the choice of commit range you want to review. Might be something to consider for deff?
agavra 8 hours ago [-]
I just built a version of this a month ago that also allows you to add review comments so you can export them back to an Agent to fix: https://github.com/agavra/tuicr
Great work on deff, would love to brainstorm here :)
teddyh 12 hours ago [-]
emacs --eval='(ediff-files "file1" "file2")'
(The “|” key toggles side-by-side view.)
flamestro 11 hours ago [-]
Yes, but emacs < vim
dingnuts 12 hours ago [-]
[dead]
tty456 7 hours ago [-]
So, basically 'vim -d' in rust? cool
sourcegrift 5 hours ago [-]
Does it show moved codeblocks like reviewboard. Is that the second screenshot
8 terminal lines are taken by the tool's UI. Could have been 2.
hatradiowigwam 12 hours ago [-]
vimdiff is pretty fast, and is likely installed on your linux system without you realizing it.
flamestro 11 hours ago [-]
Its a great tool, but misses some of the context I needed.
12 hours ago [-]
greatgib 10 hours ago [-]
It blows my mind that nowadays, some random tools on internet tells you to do "curl -fsSL https://.... | bash" to install some "binary" things and a lot of people will do it without hesitation.
It probably explains why there is so many data leaks recently but it is like we did a 20 years jump back in time in terms of security in just a few years.
flamestro 10 hours ago [-]
I get the hesitation :D But the code is open and the install.sh is as minimal as it gets tbh. Still, as said, I get the hesitation. What a time to be alive.
It does not install binaries, it builds the binary by checking out the project basically. You can also do the process manually and use the tool.
warkdarrior 10 hours ago [-]
> But the code is open and the install.sh is as minimal as it gets tbh.
I bet 99.9999% of users do not review the code nor the install script.
pwdisswordfishy 9 hours ago [-]
One day folks who live inside commandlines and TUIs all day will realize that there's nothing particular about webapps or the sandboxes that they execute in that requires we build exclusively graphical runtimes around them, instead of taking advantage of the same security and distribution model for programs accessible and usable from within terminal emulator.
jaden 9 hours ago [-]
Is it that different from downloading and running a binary?
greatgib 6 hours ago [-]
No, but who said that downloading and running a random binary found on internet is a good idea?
As I said, it's like being back 20 years back in the past.
holoduke 10 hours ago [-]
Cowboys rule the internet.
zem 10 hours ago [-]
will this play well with jj?
insane_dreamer 11 hours ago [-]
we need something like this in lazygit -- which is excellent all around but lacking in visual diffing/merging.
What is most useful though is a 3-panel setup, like JetBrains -- still the best git client I have worked with.
flamestro 11 hours ago [-]
What would the third panel contain in this case? Do you mean the setup that IntelliJ has in merge conflicts?
insane_dreamer 4 hours ago [-]
yes, it shows the final merge (what was accepted from the left and right panels); very handy
dec0dedab0de 11 hours ago [-]
looks pretty good at a glance, though I would like to see three views for handling conflicts. Target on the left, source on the right, and the combined result in the middle.
...I really just like the way the Jetbrains IDEs do it, and I wish there were a TUI version that I could launch automatically from the git cli.
Also curious why you chose Rust TUI instead of building on top of something like delta.
I admit I haven't looked super hard yet, I settled on configuring git to use delta [0] for now and I'm happy with it, but I'm curious if anyone has a workflow for reviewing/iterating on diffs in the terminal that they'd be willing to share. Also open to being told that I'm lightyears behind and that there's a better mental model for this.
[0] https://github.com/dandavison/delta/
This in conjunction with gh-dash [1] to launch a review can get you a pretty nice TUI review workflow.
[0] https://github.com/pwntester/octo.nvim
[1] https://github.com/dlvhdr/gh-dash
*Edit: I see you meant providing feedback to an agent, not a PR. Well that's what I get for reading too fast.
The two are kind of similar if I remember correctly, and both offer a lot of config options to change the style and more. I mostly use it for diffs involving long lines since it highlights changes within a line, which makes it easier to spot such edits.
I have an alias set in `~/.gitconfig` to pipe the output of `git diff` (with options) to `diff-so-fancy` with `git diffs`:
[1] https://github.com/so-fancy/diff-so-fancyOnce you submit it outputs to stdout and the agent reads your comments and actions them.
https://github.com/jfyne/meatcheck
- even faster, especially if you have couple thousand files and just want to press "u" for some time and see them very quickly all get staged
- has this split-view diff opened for a file
Otherwise tig is one of my favorite tools to quickly commit stuff without too many key presses but with review abilities, i have its "tig status" aliased to "t"
[1]: https://alexpasmantier.github.io/television/
What nobody's mentioned yet is difftastic. Takes a completely different approach - parses syntax trees instead of lines, so indentation changes and bracket shuffles don't show up as noise. Worth a look if you're comparing options.
Main question I'd have: how does it hold up on large files? 5k+ line diffs are where most of these tools either choke or produce unreadable output. That'd be the test I'd run first.
vim folds are fully programmable. For me a bigger issue was git calling vimdiff for each file, which I fixed with my own difftool: https://gist.github.com/PhilipRoman/60066716b5fa09fcabfa6c95...
(I found that my mac machine doesn't support the '-printf' option, and also I was attempting to run 'git bvd main' on a branch but it seems it does a recursive directory diff, so I'll use 'git diff --name-only' as the input to the awk command).
Edit: worked nicely! I haven't used tabs much in vim so is a slightly new workflow but otherwise very handy
And a link to an asciicinema would help a lot too.
---
Also, I'm not sure how useful the side-by-side view is.
The second example (https://github.com/flamestro/deff/blob/main/docs/example_02....) is confusing.
The left side has lines 1365-1371 having the same code as lines 1374-1380 on the right side, yet they're not aligned with each other.
Most diff views would put padding between lines 1364-1365 on the left side so lines 1365-1371 are aligned with 1374-1380 on the right side.
Great work on deff, would love to brainstorm here :)
It probably explains why there is so many data leaks recently but it is like we did a 20 years jump back in time in terms of security in just a few years.
It does not install binaries, it builds the binary by checking out the project basically. You can also do the process manually and use the tool.
I bet 99.9999% of users do not review the code nor the install script.
As I said, it's like being back 20 years back in the past.
What is most useful though is a 3-panel setup, like JetBrains -- still the best git client I have worked with.
...I really just like the way the Jetbrains IDEs do it, and I wish there were a TUI version that I could launch automatically from the git cli.